hub: add namespace access control#23949
Conversation
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
craig-osterhout
added
area/enterprise
|
Hi @craig-osterhout, shouldn't we avoid to use our names/ids and stage test repos in the examples that we give in docs ? What's the general guidance here ? |
|
@craig-osterhout can you update the reviewer to me? |
craig-osterhout
requested review from
jtwils17
and removed request for
sheltongraves
craig-osterhout
force-pushed
the
engdocs-3141
branch
from
ae7452d to
50bf875
Compare
Signed-off-by: Craig Osterhout <craig.osterhout@docker.com>
craig-osterhout
force-pushed
the
engdocs-3141
branch
from
dca8c32 to
ac49898
Compare
jtwils17
left a comment
jtwils17
left a comment
There was a problem hiding this comment.
Looks good, just a few points of clarification
|
/review |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Documentation Review
Found 1 critical issue and 2 minor issues:
Critical:
- Broken anchor link in release notes that will result in 404 error
Minor:
- Missing newlines at end of files
- Future release date
Please fix the broken link before merging. The other issues are optional improvements.
Signed-off-by: Craig Osterhout <craig.osterhout@docker.com>
|
/review |
There was a problem hiding this comment.
Documentation Review Summary
I found 3 style guide issues related to indirect language and clarity. These are all opportunities to make the documentation more direct and actionable per STYLE.md guidelines.
All issues are MEDIUM severity - they don't block the PR but would improve clarity if addressed.
content/manuals/enterprise/security/hardened-desktop/namespace-access.md
Outdated
Show resolved
Hide resolved
content/manuals/enterprise/security/hardened-desktop/namespace-access.md
Show resolved
Hide resolved
Signed-off-by: Craig Osterhout <craig.osterhout@docker.com>
|
/review |
There was a problem hiding this comment.
Documentation Review - PR #23949
✅ APPROVED
I've reviewed all the changed content in this PR and found no documentation issues. The additions are well-written, clear, and follow the documentation standards.
What was reviewed:
- New Settings page () - Comprehensive documentation for Docker Hub settings including disable public repos and default privacy
- New Namespace access control page () - Clear feature documentation with configuration steps and verification instructions
- Updated navigation and index pages - Proper integration of new content
- Release notes - Both Docker Hub and platform release notes updated appropriately
- Permissions tables - Core roles table updated with new feature permissions
- Metadata - summary.yaml properly configured
Quality highlights:
✅ Proper front matter and metadata
✅ Clear, step-by-step instructions
✅ Correct shortcode usage (summary-bar, callouts)
✅ Appropriate use of notes and important callouts
✅ Consistent with existing documentation patterns
✅ Good examples and console output formatting
No changes requested. The documentation is ready to merge.
Signed-off-by: Craig Osterhout <craig.osterhout@docker.com>
4 participants
Description
Added namespace access control feature:
Added public repo creation feature:
Related issues or tickets
ENGDOCS-3141
Reviews